Add GetBytes method with name #1197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see this overload in npgsql, Microsoft.Data.SqlClient, or MySql.Data, so it's doesn't seem to be commonly needed (and/or it has a simple workaround). OTOH, there's no compelling reason not to add it for symmetry with other APIs. @CorentinPtrl your commits are missing the DCO signoff. Can you certify the claims in https://developercertificate.org/? (An affirmative comment here is fine.) |
|
(I've fixed the spurious build error.) |
|
Yeah i agree with the DCO, but i just thought it could simplify the use of GetBytes since every other getter has his overload |
bgrainger
pushed a commit
that referenced
this pull request
Aug 26, 2022
(cherry picked from commit 522160c)
|
Added in 2.1.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just add a GetBytes method without ordinal