MariaDB version parsing evolution #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #1259 Since MariaDB server 11.0.1 (MDEV-28910) won't have "5.5.5-" prefix anymore. This PR propose to evolve server identification accordingly based on 2 principles: * version is stripped of "5.5.5-" prefix and identified as MariaDB (The only server that use 'x.y.z-' prefix is percona, but first percona 5.5 server was 5.5.7). MySQL use "x.y.z", alibaba and aurora use x.y.z.a notation) * server version string contains "MariaDB" (All mariadb connectors use/will use that exact same behavior for mariadb identification) Signed-off-by: rusher <diego.dupin@gmail.com>
bgrainger
approved these changes
Apr 20, 2023
bgrainger
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1259
Since MariaDB server 11.0.1 (MDEV-28910) doesn't have "5.5.5-" prefix anymore. This PR propose to evolve server identification based on 2 principles:
(All mariadb connectors use that exact same behavior for mariadb identification)