Improve Performance #245
Merged
Improve Performance #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This produces a 20% reduction in allocations in the "ManyRowsNewSync" scenario.
This reduces allocations in the "ManyRowsNewSync" scenario by 44%.
This reduces allocations in the "ManyRowsNewSync" scenario by 19%.
This reduces allocations in the "ManyRowsNewSync" scenario by 24%.
Also switch to using -1 as a sentinel instead of null to reuse function signature between read and write. This reduces allocations for the "ManyRowsNewSync" scenario by 49%.
This reduces allocations in the "ExecuteScalarNewAsync" scenario by 3%.
This reduces the allocations for the "ExecuteScalarNewSync" scenario by 10%.
SummaryThe connector was very memory-inefficient. The All Async methods still pay the performance penalty of constructing the async state machine (but should support higher concurrency). There is still room for further improvement in the async code paths. DetailsTimings after each commit in this PR, taken from my Windows desktop computer. Initial Timings
Rewrite ReadPayloadAsync
Rewrite ReadPacketAsync
Eagerly Create CancelAction
Inline MySqlSession.TryAsync
Lazily create CancelAction (RegisterCancel)
Convert ByteArrayReader/PayloadData to structs
Remove GetNextSequenceNumber Func<int?>
Remove async state machine from MySqlCommand
Fix unnecessary reallocation in ParseAndBindParameters
|
This makes "OpenFromPoolNewSync" 9x faster. If the client is disconnected, SendAsync should still throw a SocketException, allowing us to detect the failed connection.
|
Profiling showed that This makes Remove Socket.Poll
|
|
Further reductions in allocations, particularly for Defer lambda creation in WritePacketAsync
Defer lambda creation in WritePayloadAsync
|
|
Shipped in 0.19.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the speed and reduce the number of allocations in common scenarios, based on the recently-added BenchmarkDotNet benchmarks.