This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiling showed that Socket.Poll called from MySqlSession.TryPingAsync was taking a very long time (on .NET Framework 4.6.2 on Windows). I believe it's unnecessary, since SendAsync would throw a SocketException anyway if the ping packet can't be sent. Thus it should be safe to remove it to speed up retrieving a connection from the pool. CC @caleblloyd as this was added in 04d6e47.
This makes OpenFromPoolNewSync 9× faster and brings it within striking distance of Connector/NET's speed (which is fast, but incorrect).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.