Escape single quote and backslash when writing GUIDs as byte arrays.#265
Merged
bgrainger merged 1 commit intomysql-net:masterfrom May 26, 2017
Merged
Escape single quote and backslash when writing GUIDs as byte arrays.#265bgrainger merged 1 commit intomysql-net:masterfrom
bgrainger merged 1 commit intomysql-net:masterfrom
Conversation
bgrainger
added a commit
that referenced
this pull request
May 26, 2017
Escape single quote and backslash when writing GUIDs as byte arrays.
Member
|
Fixed in 0.19.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is copied from writing a byte array.
These byte values were not escaped when writing a GUID as a byte array, causing syntax errors when doing something like
when
OldGuids=true.Since the code is duplicated, I can refactor it into a method if we feel that's appropriate.