Reduce allocations #342
Merged
Reduce allocations #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A captured local variable was causing an unnecessary allocation of a compiler-generated class.
Removed SequenceNumber, since it was never read. Packet now essentially becomes an "alias" for ArraySegment<byte> (with a shorter name and semantic difference).
bgrainger
reviewed
Oct 1, 2017
| { | ||
| result = default(ValueTask<ArraySegment<byte>>); | ||
| return true; | ||
| } |
There was a problem hiding this comment.
packet will never be null now, because I made it a struct. OTOH, I'm not sure if it was ever null before, because it's dereferenced later in the method without a null check. (If it was possible that default(Packet) could come through, then packet.Contents.Array might throw a NullReferenceException later in the method.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Packet(which is allocated a lot) to astructManyRowsAsync"Allocated" went from 713.54 KB to 408.76 KB to 27.1 KB.ManyRowsSync"Allocated" went from 686.26 KB to 383 KB to 3.69 KB.Before
Improve ScanRowAsync
Change Packet to struct