Remove not implemented #367
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… properties but don't use.
Pull Latest Changes from source
Pull original master
…derlying is the reuse of the reference used by the ByteArrayReader. This is just a quick and dirtly fix with minimal performance impact as it only effects ColumnDefinitionPayload.
…issue underlying is the reuse of the reference used by the ByteArrayReader. This is just a quick and dirtly fix with minimal performance impact as it only effects ColumnDefinitionPayload." This reverts commit 14b38e3.
…ls. The issue underlying is the reuse of the reference used by the ByteArrayReader. This is just a quick and dirtly fix with minimal performance impact as it only effects ColumnDefinitionPayload."" This reverts commit ba26793.
|
This PR was failing so I reimplemented the fix here: ebd35aa I also saw that you added support for MySqlConnector in OrmLite; thanks! And then I saw this hack, which I wanted to help you get rid of 😄 |
|
Fixed in 0.29.1. |
|
Good stuff :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes not implemented exceptions being thrown when using certain properties. The reason being OrmLite from servicestack sets some of these properties, although it does not use them.
It also contained a fix (14b38e3 [14b38e3]) and a test for issues when reading column defs, but this has been merged away and was fixed in the commit (6b7b3f8 [6b7b3f8]).
I have left the changes to the test to catch any issues surrounding this thou :).