Remove BufferResultSets connection string setting#378
Merged
bgrainger merged 1 commit intomysql-net:masterfrom Oct 31, 2017
Merged
Remove BufferResultSets connection string setting#378bgrainger merged 1 commit intomysql-net:masterfrom
bgrainger merged 1 commit intomysql-net:masterfrom
Conversation
caleblloyd
approved these changes
Oct 26, 2017
Contributor
caleblloyd
left a comment
caleblloyd
left a comment
There was a problem hiding this comment.
It was a great feature when it was needed for EF 1.x! Does uncomplicated the code and tests now. Thanks!
Member
Author
|
@caleblloyd I'll hold off on merging and publishing this until Pomelo.EFCore is published. (Otherwise, updating MySqlConnector in a client project would break Pomelo.) |
|
Pomelo 2.0.0.1 has been published |
bgrainger
added a commit
that referenced
this pull request
Oct 31, 2017
Remove BufferResultSets connection string setting. Conflicts: .travis.yml src/MySqlConnector/MySqlClient/Results/Row.cs
bgrainger
added a commit
that referenced
this pull request
Oct 31, 2017
Remove BufferResultSets connection string setting. Conflicts: .travis.yml src/MySqlConnector/MySqlClient/Results/Row.cs
Member
Author
|
Removed in 0.30.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See PomeloFoundation/Pomelo.EntityFrameworkCore.MySql#418 (comment) for rationale.