Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BufferResultSets connection string setting #378

Merged
merged 1 commit into from Oct 31, 2017

Conversation

bgrainger
Copy link
Member

@bgrainger bgrainger commented Oct 25, 2017

@bgrainger bgrainger requested a review from caleblloyd Oct 25, 2017
Copy link
Contributor

@caleblloyd caleblloyd left a comment

It was a great feature when it was needed for EF 1.x! Does uncomplicated the code and tests now. Thanks!

@bgrainger
Copy link
Member Author

@bgrainger bgrainger commented Oct 26, 2017

@caleblloyd I'll hold off on merging and publishing this until Pomelo.EFCore is published. (Otherwise, updating MySqlConnector in a client project would break Pomelo.)

@yukozh
Copy link

@yukozh yukozh commented Oct 29, 2017

Pomelo 2.0.0.1 has been published

@bgrainger bgrainger merged commit c1ec8bf into mysql-net:master Oct 31, 2017
2 checks passed
bgrainger added a commit that referenced this issue Oct 31, 2017
Remove BufferResultSets connection string setting.

Conflicts:
	.travis.yml
	src/MySqlConnector/MySqlClient/Results/Row.cs
bgrainger added a commit that referenced this issue Oct 31, 2017
Remove BufferResultSets connection string setting.

Conflicts:
	.travis.yml
	src/MySqlConnector/MySqlClient/Results/Row.cs
@bgrainger bgrainger deleted the remove-buffer-result-sets branch Oct 31, 2017
@bgrainger
Copy link
Member Author

@bgrainger bgrainger commented Oct 31, 2017

Removed in 0.30.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants