Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix columnDefinitionPayload, skip all 0 bytes in tail #413

Closed
wants to merge 1 commit into from
Closed

fix columnDefinitionPayload, skip all 0 bytes in tail #413

wants to merge 1 commit into from

Conversation

Seamas
Copy link

@Seamas Seamas commented Dec 21, 2017

adapt Alibaba Analytic DB

@bgrainger
Copy link
Member

I assume this is related to https://www.alibabacloud.com/product/analytic-db ?

Is there any documentation related to these extra bytes, or do you have a packet capture showing them?

bgrainger added a commit that referenced this pull request Dec 21, 2017
@bgrainger
Fix column definition payload deserialization.
f2bacda 
The column definition payload does not include an array of "default values" at the end; this code appears to have been wrong for a long time, but had no effect because it harmlessly read a reserved zero byte.

Permit extra bytes at the end of the packet; this may allow greater interoperability with servers that add extra data there, e.g., (unconfirmed) Alibaba AnalyticDB #413.
@bgrainger
Copy link
Member

I found a bug in the code you opened a PR against, so I fixed it: f2bacda

At the same time, I relaxed this restriction (about the packet length), which should avoid any exception if AnalyticDB is sending extra bytes.

@bgrainger bgrainger closed this Dec 21, 2017
@bgrainger
Copy link
Member

Fixed in 0.34.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Seamas @bgrainger