fix columnDefinitionPayload, skip all 0 bytes in tail #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume this is related to https://www.alibabacloud.com/product/analytic-db ? Is there any documentation related to these extra bytes, or do you have a packet capture showing them? |
bgrainger
added a commit
that referenced
this pull request
Dec 21, 2017
The column definition payload does not include an array of "default values" at the end; this code appears to have been wrong for a long time, but had no effect because it harmlessly read a reserved zero byte. Permit extra bytes at the end of the packet; this may allow greater interoperability with servers that add extra data there, e.g., (unconfirmed) Alibaba AnalyticDB #413.
|
I found a bug in the code you opened a PR against, so I fixed it: f2bacda At the same time, I relaxed this restriction (about the packet length), which should avoid any exception if AnalyticDB is sending extra bytes. |
|
Fixed in 0.34.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adapt Alibaba Analytic DB