Support DateTimeKind connection setting.#479
Conversation
Oops, I missed this comment in the issue. I can change it, unless you don't feel strongly about it, @bgrainger. |
| #endif | ||
| Assert.Equal(15u, csb.ConnectionTimeout); | ||
| Assert.False(csb.ConvertZeroDateTime); | ||
| Assert.Equal(DateTimeKind.Unspecified, csb.DateTimeKind); |
There was a problem hiding this comment.
Needs to be in a #if !BASELINE block.
There was a problem hiding this comment.
Oops, forgot to run the BASELINE tests, thanks.
| public void QueryDateTimeKind(DateTimeKind kindOption, DateTimeKind kindIn, bool success) | ||
| { | ||
| var csb = AppConfig.CreateConnectionStringBuilder(); | ||
| csb.DateTimeKind = kindOption; |
There was a problem hiding this comment.
This line won't compile with Connector/NET so this whole test needs to be #if !BASELINE.
|
Now that you're handling all of |
|
Okay, I'll leave it as |
|
AppVeyor failed but I don't think due to my code. |
| } | ||
| } | ||
|
|
||
| [Theory] |
There was a problem hiding this comment.
MySqlDateTimeKind doesn't exist in Connector/NET so this entire test should be #ifd out.
There was a problem hiding this comment.
I think the BASELINE behaviour will be tested by DateTimeKind.Unspecified above?
|
If the tests pass, I'll rebase and force push. |
|
Rebased. |
|
Shipped in 0.40.1. |
2 participants
No changes to
DateTimeOffsetat this point.