-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement prepared commands #534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
These were moved to ICommandExecutor in 16d2c99, but don't need to support customised implementations. Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
bgrainger
force-pushed
the
prepared-commands
branch
from
July 22, 2018 04:50
e35e59f
to
5c747b2
Compare
This lays the groundwork for a BinaryRow derived class (that handles the binary protocol) to be added for prepared statements. Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
bgrainger
force-pushed
the
prepared-commands
branch
from
July 22, 2018 04:59
5c747b2
to
d7557ec
Compare
Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
bgrainger
force-pushed
the
prepared-commands
branch
2 times, most recently
from
July 22, 2018 05:12
85dd154
to
0133371
Compare
Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
Call MySqlCommand.Prepare for all commands in the test class; normally this is a no-op (since IgnorePrepare=true in the connection string), but test runners could use a custom connection string to test prepared commands. Make MySqlCommand.Prepare a no-op so that the tests pass. Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
bgrainger
force-pushed
the
prepared-commands
branch
2 times, most recently
from
July 23, 2018 23:47
bda352c
to
22f5806
Compare
This splits a single MySqlCommand.CommandText string into multiple individual SQL statements that can be prepared individually; MySQL Server doesn't support prepared commands that comprise multiple SQL statements. Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
bgrainger
force-pushed
the
prepared-commands
branch
from
July 24, 2018 03:20
22f5806
to
8f84081
Compare
Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
bgrainger
force-pushed
the
prepared-commands
branch
from
July 24, 2018 05:10
a52beb8
to
6a2840d
Compare
Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
bgrainger
force-pushed
the
prepared-commands
branch
from
July 24, 2018 05:39
e42117e
to
cee7719
Compare
Added in 0.43.0. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.