Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit of measure and default to ConnectionTimeout #727

Merged
merged 1 commit into from Oct 21, 2019

Conversation

JosephAmalfitanoSSA
Copy link
Contributor

@JosephAmalfitanoSSA JosephAmalfitanoSSA commented Oct 21, 2019

The summary is what is shown by consumers when using autocomplete. This change allows consumers to easily see the unit of measure (seconds) as well as the default value when using autocomplete/code completion.

I'm proposing this change because it wasn't clear to me if the timeout was in seconds or milliseconds. Also, i had no idea what the default is/was until I added a breakpoint in my code that was consuming this.

The summary is what is shown by consumers  when using autocomplete.  This change allows consumers to easily see the unit of measure (seconds) as well as the default value when using autocomplete/code completion.

I'm proposing this change because it wasn't clear to me if the timeout was in seconds or milliseconds. Also, i had no idea what the default is/was until I added a breakpoint in my code that was consuming this.

Signed-off-by: Amalfitano, Joseph <Joseph.Amalfitano@ssa.gov>

~
~
@JosephAmalfitanoSSA
Copy link
Contributor Author

JosephAmalfitanoSSA commented Oct 21, 2019

This picture shows the current state of the summary/tooltip. My proposed change will make it clear that the unit of measure is in seconds and the default timeout is 15 seconds.

image

@bgrainger
Copy link
Member

bgrainger commented Oct 21, 2019

Thanks for the contribution!

FYI, several of these properties are initialised from the connection string (or its defaults), and even though they don't have XML documentation, they are all described here: https://mysqlconnector.net/connection-options/

@bgrainger bgrainger merged commit 016daf8 into mysql-net:master Oct 21, 2019
20 checks passed
@bgrainger
Copy link
Member

bgrainger commented Oct 21, 2019

Added in 0.60.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants