Allows the use of snapshot isolation level on transactions#791
Merged
Conversation
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
bgrainger
reviewed
Mar 27, 2020
| { | ||
| DbConnection connection = m_connection; | ||
| m_connection.Execute(@"set global log_output = 'table';"); | ||
| m_connection.Execute(@"set global general_log = 1;"); |
Member
There was a problem hiding this comment.
Thanks for adding tests for the new behaviour!
Since multiple tests can be run in parallel, is it possible that set global general_log is capturing log statements from other tests running simultaneously on other connections? You might be able to filter by thread_id to this connection's log output (using MySqlConnection.ServerThread).
Contributor
Author
There was a problem hiding this comment.
Thanks for the tip, will try it out
Contributor
Author
There was a problem hiding this comment.
@bgrainger Are you happy with this now the tests are passing?
Member
There was a problem hiding this comment.
Sorry, I didn't see that the PR was updated and passing. Thanks for pinging me; I'll check it out soon.
bgrainger
reviewed
Mar 27, 2020
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Member
|
Thanks for the contribution! |
Member
|
Added in 0.63.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the use of using the isolation level snapshot for transactions, as per https://dev.mysql.com/doc/refman/5.7/en/commit.html