Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows the use of snapshot isolation level on transactions #791

Merged
merged 10 commits into from Apr 9, 2020

Conversation

battyejp
Copy link
Contributor

@battyejp battyejp commented Mar 27, 2020

Allows the use of using the isolation level snapshot for transactions, as per https://dev.mysql.com/doc/refman/5.7/en/commit.html

John Battye added 4 commits Mar 27, 2020
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
{
DbConnection connection = m_connection;
m_connection.Execute(@"set global log_output = 'table';");
m_connection.Execute(@"set global general_log = 1;");
Copy link
Member

@bgrainger bgrainger Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests for the new behaviour!

Since multiple tests can be run in parallel, is it possible that set global general_log is capturing log statements from other tests running simultaneously on other connections? You might be able to filter by thread_id to this connection's log output (using MySqlConnection.ServerThread).

Copy link
Contributor Author

@battyejp battyejp Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip, will try it out

Copy link
Contributor Author

@battyejp battyejp Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgrainger Are you happy with this now the tests are passing?

Copy link
Member

@bgrainger bgrainger Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see that the PR was updated and passing. Thanks for pinging me; I'll check it out soon.

John Battye added 6 commits Mar 27, 2020
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
Signed-off-by: John Battye <John.Battye@ipfin.co.uk>
@bgrainger bgrainger merged commit 1144249 into mysql-net:master Apr 9, 2020
20 checks passed
@bgrainger
Copy link
Member

@bgrainger bgrainger commented Apr 9, 2020

Thanks for the contribution!

@bgrainger
Copy link
Member

@bgrainger bgrainger commented Apr 10, 2020

Added in 0.63.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants