Add support for DataSourceInformation Schema#795
Merged
Conversation
Signed-off-by: Vincent DARON <vda@dfakto.com>
Signed-off-by: Vincent DARON <vda@dfakto.com>
Signed-off-by: Vincent DARON <vda@dfakto.com>
bgrainger
reviewed
Apr 5, 2020
|
|
||
| var row = dataTable.NewRow(); | ||
| row["CompositeIdentifierSeparatorPattern"] = @"\."; | ||
| row["DataSourceProductName"] = "MysqlConnector"; |
Member
There was a problem hiding this comment.
DataSourceProductName is "The name of the product accessed by the provider, such as 'Oracle' or 'SQLServer'." (https://docs.microsoft.com/en-us/dotnet/framework/data/adonet/common-schema-collections)
I don't know if we can accurately determine the remote database (MySQL, Percona, MariaDB, Amazon, etc.) so it might be best to just return "MySQL".
Member
|
Thanks for the contribution! I'll look over it shortly. |
bgrainger
reviewed
Apr 5, 2020
| row["CompositeIdentifierSeparatorPattern"] = @"\."; | ||
| row["DataSourceProductName"] = "MysqlConnector"; | ||
| row["DataSourceProductVersion"] = m_connection.ServerVersion; | ||
| row["DataSourceProductVersionNormalized"] = m_connection.Session.ServerVersion.Version.ToString(); |
Member
There was a problem hiding this comment.
A normalized version for the data source, such that it can be compared with
String.Compare().
There would need to be some padding here (e.g., nn.nn.nnnn) to make sure 10 doesn't compare between 1 and 2.
Change DataSourceProductVersionNormalized to have a String Comparable result Signed-off-by: Vincent DARON <vda@dfakto.com>
Member
|
Added in 0.63.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some progress on the #375 issue