Skip to content
Permalink
Browse files

Bug#23581389: SEMI-SYNC CAN'T RUN NORMALLY WHEN MANY CONNECTIONS

Post-push fix: Check for _WIN32 instead of WINDOWS. WINDOWS is only set
if including <zconf.h> (which this file happened to do indirectly
through a long #include chain), and if that link is broken, semisync
replication tests start breaking mysteriously on Windows.

Change-Id: Ie90db85ae67c718862f1d0139ff6b922f102c519
  • Loading branch information...
Tor Didriksen
Tor Didriksen committed Nov 20, 2017
1 parent 38268cd commit ec76a52483c3eec49a878e751341246be66a6802
Showing with 2 additions and 2 deletions.
  1. +2 −2 plugin/semisync/semisync_master_socket_listener.h
@@ -99,15 +99,15 @@ class Select_socket_listener
{
my_socket socket_id= m_slaves[i].sock_fd();
m_max_fd= (socket_id > m_max_fd ? socket_id : m_max_fd);
#ifndef WINDOWS
#ifndef _WIN32
if (socket_id > FD_SETSIZE)
{
sql_print_error("Semisync slave socket fd is %u. "
"select() cannot handle if the socket fd is "
"bigger than %u (FD_SETSIZE).", socket_id, FD_SETSIZE);
return false;
}
#endif //WINDOWS
#endif // _WIN32
FD_SET(socket_id, &m_init_fds);
}
return true;

0 comments on commit ec76a52

Please sign in to comment.
You can’t perform that action at this time.