Please sign in to comment.
Bug#20805298: BINLOG_ERROR_ACTION DOESN'T HANDLE SOME
FAILURES DURING BINLOG ROTATION Analysis: ======== In case of hardware errors in binlog partition during binlog rotate, we can see the following error being reported. [ERROR] The server was unable to create a new log file. An incident event has been written to the binary log which will stop the slaves. [ERROR] Can't generate a unique log-filename master-bin.(1-999) All replicas break either due to seeing incident event or simply because the dump thread cannot access binlog partition. binlog_error_action was developed for these purposes (i,e; to avoid server accepting writes even though binlog writes are failing), but it doesn't handle the above case. Fix: === An error handler has been added in such a way that, on hardware failure during rotate, it will do the specific action defined as part 'binlog_error_action' variable. Also incident event will not be written to the binary log in the above mentioned scenario.
- Loading branch information...
Showing with 158 additions and 56 deletions.
- +57 −4 mysql-test/extra/rpl_tests/rpl_binlog_error.inc
- +17 −0 mysql-test/suite/binlog/r/binlog_error_action.result
- +0 −3 mysql-test/suite/binlog/r/binlog_index.result
- +1 −3 mysql-test/suite/binlog/r/binlog_max_extension.result
- +45 −0 mysql-test/suite/binlog/t/binlog_error_action.test
- +0 −3 mysql-test/suite/binlog/t/binlog_index.test
- +1 −3 mysql-test/suite/binlog/t/binlog_max_extension.test
- +15 −7 mysql-test/suite/rpl/r/rpl_binlog_errors.result
- +15 −6 mysql-test/suite/rpl/r/rpl_gtid_binlog_errors.result
- +7 −27 sql/binlog.cc
Oops, something went wrong.