Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for nodejs 10 compatibility. #2026

Closed
wants to merge 1 commit into from
Closed

Updates for nodejs 10 compatibility. #2026

wants to merge 1 commit into from

Conversation

coreyfarrell
Copy link
Contributor

@coreyfarrell coreyfarrell commented May 25, 2018

  • Use setTimeout and .refresh if available.
  • Enable testing of nodejs 10.2.1.
  • Use 'tls.getCiphers()' if available to detect an available cipher for
    testing.

Fixes #2003.

* Use setTimeout and .refresh if available.
* Enable testing of nodejs 10.2.1.
* Use 'tls.getCiphers()' if available to detect an available cipher for
  testing.

Fixes #2003.
@ipengyo
Copy link

@ipengyo ipengyo commented Jun 6, 2018

When is this version available?

Copy link

@KyleBoyer KyleBoyer left a comment

Looks good!

@dougwilson dougwilson self-assigned this Jun 13, 2018
@dougwilson
Copy link
Member

@dougwilson dougwilson commented Jun 15, 2018

Sorry, something happened while I was waiting for a CI build on this, and didn't get back to it. Resuming work on this now.

@coreyfarrell
Copy link
Contributor Author

@coreyfarrell coreyfarrell commented Jun 15, 2018

No worries, thanks for looking into this!

@NormandoHall
Copy link

@NormandoHall NormandoHall commented Jun 18, 2018

Any news about this PR?

@KyleBoyer
Copy link

@KyleBoyer KyleBoyer commented Jun 19, 2018

@dougwilson Have you gotten any time to look at this?

@dougwilson
Copy link
Member

@dougwilson dougwilson commented Jun 19, 2018

Yea, last night I finished up fixing a back compat edge case and so am heading home soon and plan to get it all up tonight.

@KyleBoyer
Copy link

@KyleBoyer KyleBoyer commented Jun 21, 2018

@dougwilson Any new issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

5 participants