fix for two errors fPIC and dynamic plugin paremeter #2

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@mahrton

mahrton commented Aug 20, 2013

1, fPIC was required in order to make the compilation work on my computer. It might be because it's a 64 bit system and as I understand http://stackoverflow.com/questions/5311515/gcc-fpic-option should do no harm, it makes the program code work memory address independently.
2, Included -DMYSQL_DYNAMIC_PLUGIN gcc paremeter as it has been pointed out by Roland Bouman on http://dev.mysql.com/tech-resources/articles/mysql_i_s_plugins_part1-2.html (to make the "magic" work).

fix for two errors fPIC and dynamic plugin paremeter
1, fPIC was required in order to make the compilation work on my computer. It might be because it's a 64 bit system and as I understand http://stackoverflow.com/questions/5311515/gcc-fpic-option should do no harm, it makes the program code work memory address independently.
2, Included -DMYSQL_DYNAMIC_PLUGIN gcc paremeter as it has been pointed out by Roland Bouman on http://dev.mysql.com/tech-resources/articles/mysql_i_s_plugins_part1-2.html (to make the "magic" work).
@LeHibou

This comment has been minimized.

Show comment
Hide comment
@LeHibou

LeHibou Sep 1, 2013

You deserve a big friendly hug.

This option is absolutely hidden from the human world.

Good catch :)

LeHibou commented Sep 1, 2013

You deserve a big friendly hug.

This option is absolutely hidden from the human world.

Good catch :)

@mahrton

This comment has been minimized.

Show comment
Hide comment
@mahrton

mahrton Sep 2, 2013

:) thanks dude

On 1 September 2013 20:40, LeHibou notifications@github.com wrote:

You deserve a big friendly hug.

This option is absolutely hidden from the human world.

Good catch :)


Reply to this email directly or view it on GitHubhttps://github.com/mysqludf/lib_mysqludf_sys/pull/2#issuecomment-23631569
.

mahrton commented Sep 2, 2013

:) thanks dude

On 1 September 2013 20:40, LeHibou notifications@github.com wrote:

You deserve a big friendly hug.

This option is absolutely hidden from the human world.

Good catch :)


Reply to this email directly or view it on GitHubhttps://github.com/mysqludf/lib_mysqludf_sys/pull/2#issuecomment-23631569
.

@casperklein

This comment has been minimized.

Show comment
Hide comment

Thanks!!

@Spetnik

This comment has been minimized.

Show comment
Hide comment
@Spetnik

Spetnik Aug 8, 2017

Is this package still being maintained? This should have been merged a very long time ago...

Spetnik commented Aug 8, 2017

Is this package still being maintained? This should have been merged a very long time ago...

@mahrton

This comment has been minimized.

Show comment
Hide comment
@mahrton

mahrton Aug 16, 2017

@Spetnik yeah, about 4 years ago. I don't even know the status.

Hi @jasny, do you have an objection why this shouldn't be merged? I believe you are the original author of this project.

mahrton commented Aug 16, 2017

@Spetnik yeah, about 4 years ago. I don't even know the status.

Hi @jasny, do you have an objection why this shouldn't be merged? I believe you are the original author of this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment