Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goimports check do nothing since goimport is not installed for CI #450

Closed
soffokl opened this issue Oct 16, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@soffokl
Copy link
Member

commented Oct 16, 2018

We are missing goimports tool on the CI, but it succeeds somehow anyway.

bin/check_goimports
bin/check_goimports: line 23: goimports: command not found
All files are compliant to goimports.

It should fail if required dependencies not found.
Required dependencies should be installed before running it.

u5surf added a commit to u5surf/node that referenced this issue Oct 16, 2018

u5surf added a commit to u5surf/node that referenced this issue Oct 16, 2018

u5surf added a commit to u5surf/node that referenced this issue Oct 16, 2018

u5surf added a commit to u5surf/node that referenced this issue Oct 16, 2018

u5surf added a commit to u5surf/node that referenced this issue Oct 16, 2018

@tadovas tadovas self-assigned this Oct 16, 2018

@tadovas tadovas closed this in #452 Oct 17, 2018

u5surf added a commit to u5surf/node that referenced this issue Oct 18, 2018

u5surf added a commit to u5surf/node that referenced this issue Oct 18, 2018

Waldz added a commit that referenced this issue Oct 22, 2018

Merge pull request #451 from u5surf/issue-450-2
redirect stderr to stdout for goimports #450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.