Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiting the cli hangs instead of quitting #462

Closed
tcharding opened this issue Oct 18, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@tcharding
Copy link
Contributor

commented Oct 18, 2018

Running bin/run cli then entering command quit (or exit) outputs a goodbye message then prints the cli prompt again, the cli hangs at this stage (Ctl-C does not work).

@soffokl

This comment has been minimized.

Copy link
Member

commented Oct 22, 2018

I have commented in the PR:

Looks like this is a bug in the package that we are using chzyer/readline#136
It fixed in master, but we are using the latest version and we don't have the fix released.
We can workaround it somehow, or just use the master branch in dep

There is an issue, that request a new release:

@soffokl soffokl self-assigned this Oct 23, 2018

soffokl added a commit that referenced this issue Oct 23, 2018

soffokl added a commit that referenced this issue Oct 23, 2018

@soffokl soffokl closed this in #477 Oct 23, 2018

soffokl added a commit that referenced this issue Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.