Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter errors in "command_run.identity" and "location" #104

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
2 participants
@donce
Copy link
Contributor

commented Jan 21, 2018

No description provided.

@@ -9,10 +9,12 @@ import (
// Database downloaded from http://dev.maxmind.com/geoip/geoip2/geolite2/
const Database = "data/GeoLite2-Country.mmdb"

This comment has been minimized.

Copy link
@Waldz

Waldz Jan 22, 2018

Member

Code source has nothing common with environment there compiled application is executed

  • This config should be configured from CLI argument --ip-database
    OR
  • This config should be loader from ConfigDirectory + "/GeoLite2-Country.mmdb"

This comment has been minimized.

Copy link
@donce

donce Jan 22, 2018

Author Contributor

Yes - I am working on that in a separate PR, because this PR is not related to this issue.

@Waldz

Waldz approved these changes Jan 22, 2018

@donce donce merged commit 7367530 into master Jan 23, 2018

@donce donce deleted the refactor/MYST-249-command-run-identity-linter branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.