Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "password" term with "passphrase" to unify naming #109

Merged
merged 1 commit into from Jan 22, 2018

Conversation

Projects
None yet
2 participants
@donce
Copy link
Contributor

commented Jan 22, 2018

No description provided.

@@ -126,7 +126,7 @@ func (c *Command) connect(line string) {
consumerId, providerId := identities[0], identities[1]

if consumerId == "new" {
id, err := c.tequilapi.NewIdentity(identityDefaultPassword)

This comment has been minimized.

Copy link
@Waldz

Waldz Jan 22, 2018

Member

But unlock passphrase should be taken from Options.IdentityPassphrase.
And Golang will default this option to "", You dont need constant for that

This comment has been minimized.

Copy link
@donce

donce Jan 22, 2018

Author Contributor

There is no Options here - it's CLI. It should be passed in a command identity new mypassphrase - I've already created a subtask for that https://mysteriumnetwork.atlassian.net/browse/MYST-265. This subtask is only about renaming.

This comment has been minimized.

Copy link
@Waldz

Waldz Jan 22, 2018

Member

clear

@Waldz

Waldz approved these changes Jan 22, 2018

@Waldz Waldz merged commit bb7d2a8 into master Jan 22, 2018

@Waldz Waldz deleted the refactor/MYST-261-unify-passphrase-naming branch Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.