Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some of linter warnings #112

Merged
merged 1 commit into from Jan 22, 2018

Conversation

Projects
None yet
2 participants
@donce
Copy link
Contributor

commented Jan 22, 2018

Reduced linter warnings: 433 -> 383

@Waldz

Waldz approved these changes Jan 22, 2018

@@ -9,11 +9,11 @@ import (

type SessionStatsSender func(bytesSent, bytesReceived int) error

func NewSessionStatsSender(mysteriumClient server.Client, sessionId session.SessionId, signer identity.Signer) SessionStatsSender {
sessionIdString := string(sessionId)
func NewSessionStatsSender(mysteriumClient server.Client, sessionID session.SessionID, signer identity.Signer) SessionStatsSender {

This comment has been minimized.

Copy link
@Waldz

Waldz Jan 22, 2018

Member

Are You using high linter requirements? What command are You using?

This comment has been minimized.

Copy link
@donce

donce Jan 22, 2018

Author Contributor

bin/lint - which hides less important errors.

@donce donce merged commit 622073f into master Jan 22, 2018

@donce donce deleted the refactor/fix-linter-warnings branch Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.