Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime error when aborting program before http server started #114

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
2 participants
@donce
Copy link
Contributor

commented Jan 23, 2018

No description provided.

@donce donce requested review from shroomist, tadovas and Waldz Jan 23, 2018

@tadovas
Copy link
Member

left a comment

LGTM

@@ -17,3 +17,8 @@ func TestLocalAPIServerPortIsAsExpected(t *testing.T) {
server.Stop()
server.Wait()
}

func TestStopBeforeStartingListening(t *testing.T) {

This comment has been minimized.

Copy link
@tadovas

tadovas Jan 23, 2018

Member

Maybe a better test name would express why this test is needed like "StoppingServerBeforeListenning should not cause segfault" (this was the problem right?). But it's minor

@donce donce force-pushed the hotfix/api-server-stop-fix branch from 530ec55 to dfdec83 Jan 23, 2018

@tadovas
Copy link
Member

left a comment

LGTM

@donce donce merged commit 04fa384 into master Jan 23, 2018

@donce donce deleted the hotfix/api-server-stop-fix branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.