Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command run error handling, which sometimes results in infinite loop #115

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
2 participants
@donce
Copy link
Contributor

commented Jan 23, 2018

I've experienced this when port 4050 was already in use. In this case, node was running in loop without any output.

@tadovas
Copy link
Member

left a comment

How this was missed :(

@donce

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2018

@tadovas I believe no unit-tests for this class explains that :D

@donce donce merged commit 94e7949 into master Jan 23, 2018

@donce donce deleted the hotfix/fix-infinite-loop-on-error branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.