Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating identity, unlock it before registering #116

Merged
merged 2 commits into from Jan 24, 2018

Conversation

Projects
None yet
2 participants
@donce
Copy link
Contributor

commented Jan 23, 2018

Registering identity already requires identity to be unlocked, so h.manager.Unlock(id.Address, passphrase) has to be invoked before h.identityAPI.RegisterIdentity(id, h.signerFactory(id)) in UseNew method in handler.go.
Since identity registration is done inside UseNew, that's why unlocking was moved inside identity handler methods.

@tadovas
Copy link
Member

left a comment

LGTM. Anybody else?

@donce donce merged commit 618d389 into master Jan 24, 2018

@donce donce deleted the hotfix/unlock-when-creating-identity branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.