Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix country database file to be reachable in docker #117

Merged
merged 1 commit into from Jan 24, 2018

Conversation

Projects
None yet
2 participants
@donce
Copy link
Contributor

commented Jan 24, 2018

No description provided.

@@ -92,14 +93,14 @@ func (cmd *CommandRun) Run() (err error) {
return nil
}

func detectCountry() (string, error) {
func detectCountry(detector location.Detector) (string, error) {
ipifyClient := ipify.NewClient()

This comment has been minimized.

Copy link
@Waldz

Waldz Jan 24, 2018

Member

ipifyClient is already injected into command

This comment has been minimized.

Copy link
@donce

donce Jan 24, 2018

Author Contributor

Right! Updated to re-use ipifyClient

@donce donce force-pushed the hotfix/MYST-267-country-detection-database branch from b50dbe7 to 46d7f93 Jan 24, 2018

@Waldz

Waldz approved these changes Jan 24, 2018

@donce donce merged commit 173e1a5 into master Jan 24, 2018

@donce donce deleted the hotfix/MYST-267-country-detection-database branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.