Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI command for proposals #128

Merged
merged 3 commits into from Jan 31, 2018

Conversation

Projects
None yet
2 participants
@donce
Copy link
Contributor

commented Jan 31, 2018

screen shot 2018-01-31 at 11 55 21

@tadovas
Copy link
Member

left a comment

What about competing provider id as second argument to connect command? It would be super duper ultra mega awesome feature

@donce

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2018

Added provider id autocompletion (@tadovas)

@donce donce force-pushed the feature/MYST-279-proposals-cli branch from f31190a to f345fa4 Jan 31, 2018

@tadovas

This comment has been minimized.

Copy link
Member

commented Jan 31, 2018

100 bravo tokens! LGTM

for _, proposal := range proposals {
country := proposal.ServiceDefinition.LocationOriginate.Country
var countryString string
if country != nil {

This comment has been minimized.

Copy link
@tadovas

tadovas Jan 31, 2018

Member

What about ternariy operator? country == nil ? "default" : country

This comment has been minimized.

Copy link
@tadovas

tadovas Jan 31, 2018

Member

RTFM for myself. Ignore this

@tadovas
Copy link
Member

left a comment

LGTM

@donce donce merged commit b8fba15 into master Jan 31, 2018

@donce donce deleted the feature/MYST-279-proposals-cli branch Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.