Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYST-300 Update client's system dns #141

Merged

Conversation

Projects
None yet
2 participants
@Waldz
Copy link
Member

commented Feb 5, 2018

No description provided.

@Waldz Waldz requested review from ignasbernotas, tadovas, donce and zolia Feb 5, 2018

@Waldz Waldz changed the base branch from master to feature/MYST-298-rename-node-key Feb 5, 2018

@Waldz Waldz force-pushed the feature/MYST-300-update-system-dns branch from daa5dc3 to 70a6af3 Feb 5, 2018

@Waldz Waldz force-pushed the feature/MYST-298-rename-node-key branch 2 times, most recently from 61d65ab to e69322b Feb 6, 2018

@@ -64,26 +64,27 @@ func (mApi *mysteriumAPI) RegisterProposal(proposal dto_discovery.ServiceProposa
return err
}

func (mApi *mysteriumAPI) NodeSendStats(nodeKey string, signer identity.Signer) error {
func (mApi *mysteriumAPI) SendProposalStats(providerID string, signer identity.Signer) error {

This comment has been minimized.

Copy link
@zolia

zolia Feb 6, 2018

Member

not sure what You mean by this name...

This comment has been minimized.

Copy link
@zolia

zolia Feb 6, 2018

Member

theres no proposal anywhere, just providerID

func (client *ClientFake) NodeSendStats(nodeKey string, signer identity.Signer) (err error) {
log.Info(mysteriumAPILogPrefix, "Node stats sent: ", nodeKey)
// SendProposalStats heartbeats that service proposal is still active
func (client *ClientFake) SendProposalStats(providerID string, signer identity.Signer) (err error) {

This comment has been minimized.

Copy link
@zolia

zolia Feb 6, 2018

Member

same here

@Waldz Waldz force-pushed the feature/MYST-300-update-system-dns branch from f7c6c68 to 10c52e1 Feb 6, 2018

@Waldz Waldz force-pushed the feature/MYST-300-update-system-dns branch from 10c52e1 to 974b193 Feb 6, 2018

@zolia

zolia approved these changes Feb 6, 2018

@Waldz Waldz merged commit a6a1c38 into feature/MYST-298-rename-node-key Feb 6, 2018

@Waldz Waldz deleted the feature/MYST-300-update-system-dns branch Feb 6, 2018

@Waldz Waldz restored the feature/MYST-300-update-system-dns branch Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.