Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYST-298 Possibility to inject identity to Docker container #153

Merged
merged 12 commits into from Feb 12, 2018

Conversation

Projects
None yet
3 participants
@Waldz
Copy link
Member

commented Feb 10, 2018

If You want still run Docker containers:

sudo chmod -R og+rx ~/.mysterium

@Waldz Waldz force-pushed the feature/MYST-298-injectable-identity branch from 7d08867 to adaa179 Feb 10, 2018

# Client connects to node
bin/client_build
bin/client_run --node 123456
bin/client_run --cli

This comment has been minimized.

Copy link
@donce

donce Feb 12, 2018

Contributor

This won't start client itself - please use bin/cli_client_runor run client separately.

This comment has been minimized.

Copy link
@Waldz

Waldz Feb 12, 2018

Author Member

Fixed

@@ -36,11 +36,11 @@ docker-compose up broker
# Start node
bin/server_build
bin/server_run --node 123456
bin/server_run --identity=0x123456..

This comment has been minimized.

Copy link
@donce

donce Feb 12, 2018

Contributor

Why not omit identity parameter? It will create a new default identity and re-use the same identity later, which seems easier for contributors at this point :)

This comment has been minimized.

Copy link
@Waldz

Waldz Feb 12, 2018

Author Member

Fixed

INSTALL.md Outdated
@@ -84,7 +90,7 @@ sudo mysterium_server --config-dir=/etc/mysterium-node --node=123456
### Running
```bash
mysterium_client --help
sudo mysterium_client --node=123456
sudo mysterium_client --cli

This comment has been minimized.

Copy link
@donce

donce Feb 12, 2018

Contributor

This doesn't start client as well.

This comment has been minimized.

Copy link
@Waldz

Waldz Feb 12, 2018

Author Member

Fixed

alias myst-client="myst-home && bin/client_build && bin/client_run"
alias myst-server="myst-home && bin/server_build && bin/server_run"

This comment has been minimized.

Copy link
@donce

donce Feb 12, 2018

Contributor

Missing endline.

This comment has been minimized.

Copy link
@Waldz

Waldz Feb 12, 2018

Author Member

Fixed

MYSTERIUM_CLIENT_TEQUILAPI_ADDRESS="localhost"

# Port for listening incoming api requests
MYSTERIUM_CLIENT_TEQUILAPI_PORT="4050"

This comment has been minimized.

Copy link
@donce

donce Feb 12, 2018

Contributor

Endline missing.

This comment has been minimized.

Copy link
@Waldz

Waldz Feb 12, 2018

Author Member

Fixed

MYSTERIUM_SERVER_COUNTRY_DATABASE=""

# Service location country. If not given country is autodetected
MYSTERIUM_SERVER_COUNTRY=""

This comment has been minimized.

Copy link
@donce

donce Feb 12, 2018

Contributor

Newline missing.

This comment has been minimized.

Copy link
@Waldz

Waldz Feb 12, 2018

Author Member

Fixed

@donce
Copy link
Contributor

left a comment

Comment before.

@donce

donce approved these changes Feb 12, 2018

@Waldz Waldz merged commit d511c36 into master Feb 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Waldz Waldz deleted the feature/MYST-298-injectable-identity branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.