Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter warnings #168

Merged
merged 2 commits into from Feb 21, 2018

Conversation

Projects
None yet
3 participants
@donce
Copy link
Contributor

commented Feb 20, 2018

No description provided.

@donce donce requested review from shroomist, ignasbernotas, tadovas and zolia Feb 20, 2018

@@ -16,46 +16,46 @@ func NewKeystoreFake() *keyStoreFake {
return &keyStoreFake{}
}

func (self *keyStoreFake) Accounts() []accounts.Account {
return self.AccountsMock
func (keyStore *keyStoreFake) Accounts() []accounts.Account {

This comment has been minimized.

Copy link
@Waldz

Waldz Feb 20, 2018

Member

Is not keystore single word?

This comment has been minimized.

Copy link
@donce

donce Feb 21, 2018

Author Contributor

From quick googling, it seems that it's 2 words - didn't find such word as "keystore".

@donce donce force-pushed the refactor/linter-warnings branch from 175f2be to 76d75aa Feb 21, 2018

@tadovas
Copy link
Member

left a comment

LGTM

@donce donce merged commit edfe01f into master Feb 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@donce donce deleted the refactor/linter-warnings branch Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.