Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/MYST-149 command line option to specify openvpn executable #173

Merged

Conversation

Projects
None yet
3 participants
@tadovas
Copy link
Member

commented Feb 22, 2018

No description provided.

@shroomist
Copy link
Contributor

left a comment

lgtm

"openvpn.binary",
"openvpn", //search in $PATH by default,
"openvpn binary to use for Open VPN connections",
)

This comment has been minimized.

Copy link
@ignasbernotas

ignasbernotas Feb 22, 2018

Member

Would be nice to output an error and kill the client if openvpn isn't found, otherwise you'll only find that out during connect.

This comment has been minimized.

Copy link
@tadovas

tadovas Feb 22, 2018

Author Member

That was my idea for next PR - on client/server startup execute openvpn.binary --version - print it if successfull, fail with error otherwise :)

@tadovas tadovas merged commit 7ce50af into master Feb 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tadovas tadovas deleted the feature/MYST-149-add-runtime-option-for-vpn-executable branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.