Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase NATS sender timeout to avoid early timeouts #174

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
2 participants
@donce
Copy link
Contributor

commented Feb 22, 2018

0.5s is too optimistic - we're making assumption that network is quite fast. With 2 seconds, we'll be on the safe side.

@donce donce requested review from tadovas, Waldz and zolia Feb 22, 2018

@donce donce force-pushed the feature/increase-nats-request-timeout branch from 297a270 to b1748ce Feb 23, 2018

@Waldz

Waldz approved these changes Feb 23, 2018

@Waldz Waldz merged commit 14141af into master Feb 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@donce donce deleted the feature/increase-nats-request-timeout branch Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.