Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYST-362 prevent server premature shutdown on missing discovery ping #179

Merged

Conversation

Projects
None yet
2 participants
@zolia
Copy link
Member

commented Feb 26, 2018

No description provided.

log.Error("Failed to ping proposal", err)
cmd.Kill()
// do not stop server on missing ping to discovery. More on this in MYST-362 and MYST-370

This comment has been minimized.

Copy link
@tadovas

tadovas Feb 26, 2018

Member

Maybe 'failed' instead of 'missing'. Also do we really need to write ticket numbers here?

@tadovas
Copy link
Member

left a comment

LGTM

@zolia zolia merged commit 0bfaa41 into master Feb 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zolia zolia deleted the BUG/MYST-362-unexpected-server-shutdown-on-missing-discovery branch Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.