Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/MYST-393 #191

Merged
merged 3 commits into from Mar 2, 2018

Conversation

Projects
None yet
2 participants
@tadovas
Copy link
Member

commented Mar 2, 2018

No description provided.

password := event.env["password"]
err := m.authenticateClient(event.clientID, event.clientKey, username, password)
if err != nil {
log.Critical("Unable to authenticate client. Error: ", err)

This comment has been minimized.

Copy link
@zolia

zolia Mar 2, 2018

Member

I woudn't say its critical. Critical usually means that application cannot proceed. In this case just 1 client..

@zolia
Copy link
Member

left a comment

nice remake. 💯

@tadovas tadovas force-pushed the bugfix/node-disconnects-innocent-client branch from 002f71d to 3b3ea48 Mar 2, 2018

@zolia

zolia approved these changes Mar 2, 2018

@tadovas tadovas merged commit a5de8ea into master Mar 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tadovas tadovas deleted the bugfix/node-disconnects-innocent-client branch Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.