Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYST-413 Optimize dockers to have more cached layers #202

Merged
merged 4 commits into from Mar 16, 2018

Conversation

Projects
None yet
2 participants
@Waldz
Copy link
Member

commented Mar 12, 2018

No description provided.

@Waldz Waldz requested review from tadovas, donce and zolia Mar 12, 2018

@Waldz Waldz changed the title MYST-413 Optimize dockers MYST-413 Optimize dockers to have more cached layers Mar 12, 2018

@Waldz Waldz force-pushed the feature/MYST-413-optimize-dockers branch from b034eae to 1a1a7e8 Mar 13, 2018

@tadovas

This comment has been minimized.

Copy link
Member

commented Mar 14, 2018

What about alpine image building? Needs to be migrated to our builder too?

@Waldz

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2018

Had same idea, but alpine currently compiled in alpine, and builder is Ubuntu image

NETWORKSETUP=/usr/sbin/networksetup
if [ ! -x "$NETWORKSETUP" ]; then

This comment has been minimized.

Copy link
@tadovas

tadovas Mar 15, 2018

Member

NETWORKSETUP=(which networksetup)
if [ -n "$NETWORKSETUP" ]; then //not OSX
don't rely on hardcoded path - maybe we decide to bundle our own

This comment has been minimized.

Copy link
@Waldz

Waldz Mar 15, 2018

Author Member

Removed my logic, waiting for your fix

@tadovas
Copy link
Member

left a comment

LGTM

@Waldz Waldz merged commit 3e554f0 into master Mar 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Waldz Waldz deleted the feature/MYST-413-optimize-dockers branch Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.