Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/fix-non-deterministic-cancelable-tests #215

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
3 participants
@tadovas
Copy link
Member

commented Apr 6, 2018

No description provided.

@Waldz

Waldz approved these changes Apr 6, 2018

@@ -19,17 +19,6 @@ func TestBlockingFunctionResultIsPropagatedToCaller(t *testing.T) {
assert.Equal(t, errors.New("message"), err)
}

func TestBlockingFunctionIsCancelledIfCancelWasCalled(t *testing.T) {

This comment has been minimized.

Copy link
@Waldz

Waldz Apr 6, 2018

Member

Removing 2 tests?

This comment has been minimized.

Copy link
@tadovas

tadovas Apr 6, 2018

Author Member

Yeah. One test was testing non-existent case (false positive), another was duplicating test.

@tadovas

This comment has been minimized.

Copy link
Member Author

commented Apr 6, 2018

@donce @zolia your review?

@donce

donce approved these changes Apr 6, 2018

@tadovas tadovas merged commit a93c63e into master Apr 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tadovas tadovas deleted the hotfix/fix-non-deterministic-cancelable-tests branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.