Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reconnect issue to gnatsd #221

Merged
merged 3 commits into from Apr 11, 2018

Conversation

Projects
None yet
4 participants
@zolia
Copy link
Member

commented Apr 11, 2018

No description provided.

zolia added some commits Apr 11, 2018

@zolia zolia requested review from ignasbernotas, tadovas, donce and Waldz Apr 11, 2018

@ignasbernotas
Copy link
Member

left a comment

LGTM

@@ -18,7 +19,7 @@ func NewAddress(topic string, addresses ...string) *AddressNATS {

// NewAddressGenerate generates NATS address for current node
func NewAddressGenerate(brokerIP string, myID identity.Identity) *AddressNATS {
address := "nats://" + brokerIP + ":4222"
address := "nats://" + brokerIP + ":" + strconv.Itoa(BrokerPort)

This comment has been minimized.

Copy link
@donce

donce Apr 11, 2018

Contributor

Sprintf

@zolia zolia dismissed stale reviews from Waldz, donce, and ignasbernotas via 24fad67 Apr 11, 2018

@Waldz

Waldz approved these changes Apr 11, 2018

@zolia zolia merged commit e52f0ea into master Apr 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zolia zolia deleted the HOTFIX/MYST-504-nats-client-stops-reconnecting branch Apr 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.