Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/myst 372 unregister proposal #232

Merged
merged 15 commits into from Apr 27, 2018

Conversation

Projects
None yet
5 participants
@zolia
Copy link
Member

commented Apr 26, 2018

No description provided.

Antanas V added some commits Mar 30, 2018

Antanas V
Antanas V
@tadovas

This comment has been minimized.

Copy link
Member

commented on cmd/commands/server/command_server.go in e596719 Mar 30, 2018

It shouldn't be expored, as its used package internally only.

tadovas and others added some commits Apr 12, 2018

Update CONTRIBUTING doc (#229)
* update doc: add .env example

* add help docs for client cli

* revert changes on unrelated lines

* add explanation for NATS_SERVER_IP

* modify .env_example instead of massive docs

@zolia zolia requested review from donce, tadovas and Waldz as code owners Apr 26, 2018

zolia added some commits Apr 26, 2018


var (
myID = identity.FromAddress("identity-1")
activeProviderID = identity.FromAddress("vpn-node-1")

This comment has been minimized.

Copy link
@Waldz

Waldz Apr 26, 2018

Member

unused variables

}
}
}()
go pingProposalLoop(proposal, cmd.mysteriumClient, signer, stopPinger)

This comment has been minimized.

Copy link
@Waldz

Waldz Apr 26, 2018

Member

Code is too fat here. Would be nice to move to something like discoveryAnnouncementLoop()

@@ -112,21 +112,7 @@ func (cmd *Command) Start() (err error) {
}

This comment has been minimized.

Copy link
@Waldz

Waldz Apr 26, 2018

Member

Dont block cmd.Start() with loops

zolia added some commits Apr 26, 2018

@Waldz

Waldz approved these changes Apr 27, 2018

@tadovas
Copy link
Member

left a comment

LGTM

@zolia zolia merged commit a7be288 into master Apr 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zolia zolia deleted the feature/MYST-372-unregister-proposal branch Apr 27, 2018

@Waldz Waldz referenced this pull request May 2, 2018

Closed

add UnregisterProposal #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.