Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notify on explicit exit openvpn flag #233

Merged

Conversation

Projects
None yet
3 participants
@tadovas
Copy link
Member

commented May 2, 2018

Add these flags to add a chance for graceful openvpn connection shutdown from both server and client sides (instead of waiting and timing out on TLS reauth)

@tadovas tadovas requested a review from zolia May 2, 2018

@tadovas tadovas requested review from donce and Waldz as code owners May 2, 2018

@Waldz

Waldz approved these changes May 2, 2018

@@ -30,6 +30,7 @@ func NewServerConfig(
config.SetPingTimerRemote()
config.SetPersistTun()
config.SetPersistKey()
config.setFlag("explicit-exit-notify")

This comment has been minimized.

Copy link
@Waldz

Waldz May 2, 2018

Member

Would be nice to have comment that problem it fixes (command, commit, anythere)

This comment has been minimized.

Copy link
@tadovas

tadovas May 2, 2018

Author Member

Good point for the future

@zolia

zolia approved these changes May 2, 2018

@tadovas tadovas merged commit e99412a into master May 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tadovas tadovas deleted the bugfix/MYST-528-gracefully-disconnect-management-interface branch May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.