Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go vet to check for dead code #237

Merged
merged 4 commits into from May 14, 2018

Conversation

Projects
None yet
3 participants
@donce
Copy link
Contributor

commented May 11, 2018

Dead code is no good. Also, go report card runs go vet, so not having dead code increases our score as well :)

go vet supports multiple checks - not sure if others are needed, but we can add more rules if we find them useful :)

@donce donce requested review from tadovas, Waldz and zolia May 11, 2018

@zolia
Copy link
Member

left a comment

I suggest calling bin/test bin/lint_git bin/vet from one script /bin/test_commit

@donce donce force-pushed the refactor/vet branch from 2d62198 to 24e248c May 11, 2018

@donce

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2018

@zolia added lint_git script

@@ -0,0 +1 @@
bin/test && bin/vet && bin/lint_git

This comment has been minimized.

Copy link
@Waldz

Waldz May 11, 2018

Member

What is purpose of bin/test_commit helper?
Example usage documentation missing.

This comment has been minimized.

Copy link
@donce

donce May 14, 2018

Author Contributor

@Waldz added docs.

@donce donce force-pushed the refactor/vet branch from 76c3e85 to 6b6b7bd May 14, 2018

@Waldz

Waldz approved these changes May 14, 2018

@zolia

zolia approved these changes May 14, 2018

@donce donce force-pushed the refactor/vet branch from 45141ac to 4fc342c May 14, 2018

@donce donce merged commit 4eb60b5 into master May 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@donce donce deleted the refactor/vet branch May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.