Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/unregistered provider print fix #238

Merged
merged 5 commits into from May 14, 2018

Conversation

Projects
None yet
4 participants
@zolia
Copy link
Member

commented May 11, 2018

No description provided.

@zolia zolia requested review from donce, tadovas and Waldz as code owners May 11, 2018

@donce

donce approved these changes May 11, 2018

@@ -53,7 +53,7 @@ services:
MYSQL_PASSWORD: myst_api

discovery:
image: mysteriumnetwork/mysterium-api:0.1.7
image: mysteriumnetwork/mysterium-api:latest

This comment has been minimized.

Copy link
@tadovas

tadovas May 11, 2018

Member

Do we really need latest here? I would like to have hardcoded API version against which we are running e2e tests - otherwise tests will become non-deterministic - in case of api version bump, they will start to fail.
For future - maybe we can define two api containers - stable version and latest and run tests against both of them.

This comment has been minimized.

Copy link
@Waldz

Waldz May 11, 2018

Member

Does not integrations test have a purpose to identify any service that broke after changes?
it means:

  • it should be in separate repo
  • any component (node, api) should trigger an integration check

This comment has been minimized.

Copy link
@tadovas

tadovas May 11, 2018

Member

Normally yes. In this case - it's node integration testing not the whole system and we are testing node behaviour against specific api version

@Waldz

Waldz approved these changes May 14, 2018

@zolia zolia merged commit 06300d9 into master May 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zolia zolia deleted the HOTFIX/unregistered-provider-print-fix branch May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.