Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license headers #242

Merged
merged 4 commits into from May 18, 2018

Conversation

Projects
None yet
4 participants
@donce
Copy link
Contributor

commented May 17, 2018

No description provided.

@donce donce requested review from tadovas, Waldz and zolia May 17, 2018

@Waldz

This comment has been minimized.

Copy link
Member

commented May 17, 2018

Need Travis check for future generations. See ideas in MYST-487

@@ -1,3 +1,20 @@
/*
* Copyright (C) 2018 The Mysterium Network Authors

This comment has been minimized.

Copy link
@Waldz

Waldz May 17, 2018

Member

Should be text same as in LICENCE file

This comment has been minimized.

Copy link
@donce

donce May 18, 2018

Author Contributor

Done.

@tadovas

This comment has been minimized.

Copy link
Member

commented May 18, 2018

Also sign-off check in github?

@donce

This comment has been minimized.

Copy link
Contributor Author

commented May 18, 2018

@Waldz @tadovas you're talking about other subtasks of MYST-487. This is just one of subtasks, MYST-242.

@donce donce force-pushed the feature/MYST-490-license-header branch from 737dc35 to 6bf8eac May 18, 2018

@donce

This comment has been minimized.

Copy link
Contributor Author

commented May 18, 2018

I'll add instructions with screenshots on how to setup GoLand for this after we've merged this PR :)

@tadovas

This comment has been minimized.

Copy link
Member

commented May 18, 2018

@Waldz got it. LGTM

@tadovas
Copy link
Member

left a comment

LGTM

@zolia

zolia approved these changes May 18, 2018

@donce donce merged commit c88d25e into master May 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@donce donce deleted the feature/MYST-490-license-header branch May 18, 2018

@Waldz Waldz restored the feature/MYST-490-license-header branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.