Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go fmt check to CI #249

Merged
merged 2 commits into from May 23, 2018

Conversation

Projects
None yet
3 participants
@donce
Copy link
Contributor

commented May 22, 2018

screen shot 2018-05-21 at 15 00 23

screen shot 2018-05-21 at 15 00 43

@donce donce requested review from tadovas, Waldz and zolia May 22, 2018

# Checks if all project files are formatted using go fmt
#
# Usage example:
#> bin/check_gofmt

This comment has been minimized.

Copy link
@zolia

zolia May 22, 2018

Member

bin/check_go_fmt typo

This comment has been minimized.

Copy link
@donce

donce May 22, 2018

Author Contributor

Fixed

@donce donce force-pushed the refactor/ci-go-fmt branch from 2458a19 to 808aa4e May 22, 2018

@zolia

zolia approved these changes May 22, 2018

@tadovas
Copy link
Member

left a comment

LGTM
But perhaps source checking (vet fmt) should be before test execution

@donce donce force-pushed the refactor/ci-go-fmt branch from c2af724 to 4f0f68b May 23, 2018

@donce donce merged commit d5a60b5 into master May 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@donce donce deleted the refactor/ci-go-fmt branch May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.