Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic request timeout #251

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
3 participants
@zolia
Copy link
Member

commented May 22, 2018

this timeout covers all request phases

@zolia zolia requested review from donce, tadovas and Waldz as code owners May 22, 2018

},
Timeout: requestTimeout,

This comment has been minimized.

Copy link
@donce

donce May 22, 2018

Contributor

So the difference is that Timeout includes all processes, while ResponseHeaderTimeout is just one of process (getting headers)?

ResponseHeaderTimeout:

// ResponseHeaderTimeout, if non-zero, specifies the amount of
// time to wait for a server's response headers after fully
// writing the request (including its body, if any). This
// time does not include the time to read the response body.

Timeout:

// Timeout specifies a time limit for requests made by this
// Client. The timeout includes connection time, any
// redirects, and reading the response body. The timer remains
// running after Get, Head, Post, or Do return and will
// interrupt reading of the Response.Body.
//
// A Timeout of zero means no timeout.
//
// The Client cancels requests to the underlying Transport
// using the Request.Cancel mechanism. Requests passed
// to Client.Do may still set Request.Cancel; both will
// cancel the request.
//
// For compatibility, the Client will also use the deprecated
// CancelRequest method on Transport if found. New
// RoundTripper implementations should use Request.Cancel
// instead of implementing CancelRequest.

This comment has been minimized.

Copy link
@zolia

zolia May 22, 2018

Author Member

exactly.

This comment has been minimized.

Copy link
@tadovas

tadovas May 22, 2018

Member

💯 tokens

@tadovas
Copy link
Member

left a comment

LGTM

},
Timeout: requestTimeout,

This comment has been minimized.

Copy link
@tadovas

tadovas May 22, 2018

Member

💯 tokens

@donce

donce approved these changes May 22, 2018

@zolia zolia merged commit 5747c0d into master May 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zolia zolia deleted the feature/MYST-537-ping-proposal-stops branch May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.