Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved openvpn management from unix socket to TCP to support windows #252

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Projects
None yet
4 participants
@ignasbernotas
Copy link
Member

commented May 23, 2018

No description provided.

@ignasbernotas ignasbernotas requested review from tadovas, donce, Waldz and zolia May 23, 2018

@ignasbernotas ignasbernotas force-pushed the hotfix/management-communication branch from 66b8197 to d7c86e3 May 23, 2018

@@ -86,6 +85,9 @@ func (client *openVpnClient) Start() error {
return err
}

addr := client.management.ActiveSocketAddress()

This comment has been minimized.

Copy link
@tadovas

tadovas Jun 5, 2018

Member

We don't need directoryRuntime anymore as a parameter? In that case it can be removed

func (management *Management) SocketAddress() string {
return management.socketAddress
// ActiveSocketAddress returns management socket address
func (management *Management) ActiveSocketAddress() *net.TCPAddr {

This comment has been minimized.

Copy link
@tadovas

tadovas Jun 5, 2018

Member

Maybe net.Addr is enough? net.TCPAddr is too specific.

// Start the management interface (if it isnt already started)
if err := server.management.Start(); err != nil {
return err
}

addr := server.management.ActiveSocketAddress()

This comment has been minimized.

Copy link
@tadovas

tadovas Jun 5, 2018

Member

directoryRuntime parameter can be removed?

@@ -86,6 +85,9 @@ func (client *openVpnClient) Start() error {
return err
}

addr := client.management.ActiveSocketAddress()
client.config.SetManagementAddress(addr.IP.String(), addr.Port)

This comment has been minimized.

Copy link
@zolia

zolia Jun 5, 2018

Member

Why not just pass addr? More generic and less verbose.

@tadovas
Copy link
Member

left a comment

LGTM

@ignasbernotas ignasbernotas dismissed stale reviews from tadovas and Waldz via db6fa03 Jun 5, 2018

@ignasbernotas ignasbernotas force-pushed the hotfix/management-communication branch from 4322565 to db6fa03 Jun 5, 2018

@tadovas
Copy link
Member

left a comment

reLGTMed

@ignasbernotas ignasbernotas dismissed stale reviews from Waldz and tadovas via d32e5c4 Jun 5, 2018

@ignasbernotas ignasbernotas force-pushed the hotfix/management-communication branch from db6fa03 to d32e5c4 Jun 5, 2018

@tadovas

tadovas approved these changes Jun 5, 2018

Copy link
Member

left a comment

LGTM

@Waldz

Waldz approved these changes Jun 5, 2018

@ignasbernotas ignasbernotas merged commit 37bc095 into master Jun 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ignasbernotas ignasbernotas deleted the hotfix/management-communication branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.