Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYST-578 Start using XGO in CI flow #264

Merged
merged 4 commits into from Jun 13, 2018

Conversation

Projects
None yet
3 participants
@Waldz
Copy link
Member

commented Jun 9, 2018

No description provided.

Brake client and server taring into 2 scripts
Signed-off-by: Waldz <valdas@mysterium.network>

@Waldz Waldz requested review from ignasbernotas, tadovas, donce and zolia Jun 9, 2018

@Waldz Waldz force-pushed the feature/MYST-578-xgo-in-ci branch 7 times, most recently from 144d412 to eb4dc15 Jun 9, 2018

Waldz added some commits Jun 9, 2018

Convert standalone tarball as one of packages
Signed-off-by: Waldz <valdas@mysterium.network>
Start using XGO in CI flow
Signed-off-by: Waldz <valdas@mysterium.network>
Install XGO to Travis machine
Signed-off-by: Waldz <valdas@mysterium.network>

@Waldz Waldz force-pushed the feature/MYST-578-xgo-in-ci branch from eb4dc15 to 54e07ff Jun 12, 2018

PACKAGE_FILE="${DIR_BUILD}/`basename -s .exe ${BINARY}`.tar.gz"

# Put all files to package directory (to avoid preserving directory structure)
DIR_TEMP=`mktemp -d ${DIR_BUILD}/${tempname}.XXXXXX`

This comment has been minimized.

Copy link
@ignasbernotas

ignasbernotas Jun 12, 2018

Member

what's the XXXXXX for?

This comment has been minimized.

Copy link
@Waldz

Waldz Jun 12, 2018

Author Member

It's template for tmp directory generation

This comment has been minimized.

Copy link
@donce
@@ -0,0 +1,22 @@
#!/bin/bash

This comment has been minimized.

Copy link
@ignasbernotas

ignasbernotas Jun 12, 2018

Member

This is identical to bin/client_package_standalone except for binary name. Couldn't we use a single script for both of these?

This comment has been minimized.

Copy link
@ignasbernotas

ignasbernotas Jun 12, 2018

Member

If not, then could we at least start to tidy up the file structure in bin/ separate the node from client scripts?

This comment has been minimized.

Copy link
@Waldz

Waldz Jun 12, 2018

Author Member

Soon we will migrate to single binary mysterium_node, so I care about it much ATM

@donce

donce approved these changes Jun 12, 2018


set -e

BINARY=${BINARY:="build/server/mysterium_server"}

This comment has been minimized.

Copy link
@donce

donce Jun 12, 2018

Contributor

What does this syntax mean?

This comment has been minimized.

Copy link
@Waldz

Waldz Jun 12, 2018

Author Member

Variable can be passed to script via environment variables, but has default value

PACKAGE_FILE="${DIR_BUILD}/`basename -s .exe ${BINARY}`.tar.gz"

# Put all files to package directory (to avoid preserving directory structure)
DIR_TEMP=`mktemp -d ${DIR_BUILD}/${tempname}.XXXXXX`

This comment has been minimized.

Copy link
@donce
PACKAGE_FILE="${DIR_BUILD}/`basename -s .exe ${BINARY}`.tar.gz"

# Put all files to package directory (to avoid preserving directory structure)
DIR_TEMP=`mktemp -d ${DIR_BUILD}/${tempname}.XXXXXX`

This comment has been minimized.

Copy link
@donce

donce Jun 12, 2018

Contributor

Where does this tempname come from? :O

This comment has been minimized.

Copy link
@Waldz

Waldz Jun 12, 2018

Author Member

mkdir templating has some predefined variables

DIR_BUILD="build/package"
PACKAGE_FILE="${DIR_BUILD}/`basename -s .exe ${BINARY}`.tar.gz"

# Put all files to package directory (to avoid preserving directory structure)

This comment has been minimized.

Copy link
@donce

donce Jun 12, 2018

Contributor

to avoid preserving - did you mean to preserve?

This comment has been minimized.

Copy link
@Waldz

Waldz Jun 12, 2018

Author Member

No. By default, mkdir preserves directory structure of global paths

@ignasbernotas
Copy link
Member

left a comment

LGTM

@Waldz Waldz merged commit ed687c4 into master Jun 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Waldz Waldz deleted the feature/MYST-578-xgo-in-ci branch Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.