Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYST-590 terms for deb install #277

Merged
merged 5 commits into from Jul 11, 2018

Conversation

Projects
None yet
3 participants
@zolia
Copy link
Member

commented Jul 3, 2018

debconf based popup to accept link to terms

@zolia zolia requested review from donce, tadovas and Waldz as code owners Jul 3, 2018

@zolia zolia changed the title WIP: terms for deb install WIP: MYST-590 terms for deb install Jul 3, 2018

@@ -1,15 +1,27 @@
#!/bin/bash

if [ "$1" = "purge" -a -e /usr/share/debconf/confmodule ]; then

This comment has been minimized.

Copy link
@Waldz

Waldz Jul 5, 2018

Member

Such silently fails are very strange

This comment has been minimized.

Copy link
@zolia

zolia Jul 5, 2018

Author Member

-a -e /usr/share/debconf/confmodule checks for existence of debconf package. And purge does not and must not fail.

# Source debconf library.
. /usr/share/debconf/confmodule
# Remove my changes to the db.
db_purge || true

This comment has been minimized.

Copy link
@Waldz

Waldz Jul 5, 2018

Member

Same here

@@ -11,6 +11,7 @@ Group=mysterium-node

RuntimeDirectory=mysterium-node
RuntimeDirectoryMode=0750
LogsDirectory=mysterium-client

This comment has been minimized.

Copy link
@Waldz

Waldz Jul 5, 2018

Member

It's server_package..., whould be mysterium-client?

@zolia zolia force-pushed the feature/MYST-590-deb-license-accept-link branch from d1d4c36 to 6dfdfe3 Jul 5, 2018

zolia added some commits Jun 25, 2018

@zolia zolia force-pushed the feature/MYST-590-deb-license-accept-link branch from 6dfdfe3 to 92c6961 Jul 10, 2018

@zolia zolia changed the title WIP: MYST-590 terms for deb install MYST-590 terms for deb install Jul 10, 2018

@tadovas
Copy link
Member

left a comment

LGTM

@Waldz

Waldz approved these changes Jul 11, 2018

@Waldz Waldz merged commit 2f3a9ba into master Jul 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Waldz Waldz deleted the feature/MYST-590-deb-license-accept-link branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.