Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYST-566 Release Docker artifacts #280

Merged
merged 10 commits into from Jul 6, 2018

Conversation

Projects
None yet
3 participants
@Waldz
Copy link
Member

commented Jul 4, 2018

No description provided.

@Waldz Waldz requested review from interro, donce and zolia Jul 4, 2018

@Waldz Waldz requested a review from tadovas as a code owner Jul 4, 2018

@Waldz Waldz force-pushed the Waldz:feature/MYST-566-release-docker branch from 202d9c3 to 9991d91 Jul 4, 2018

# Uploads several versions
# > docker_release_image mysteriumnetwork/mysterium-node ubuntu ${VERSION}-ubuntu ubuntu
docker_release_image () {
DOCKER_IMAGE=$1

This comment has been minimized.

Copy link
@tadovas

tadovas Jul 4, 2018

Member

use this approach for consuming bash parameters:
DOCKER_IMAGE=$1; shift;
DOCKER_BUILD_TAG=$1; shift;

this way you will keep param consuming and shifting in sync

This comment has been minimized.

Copy link
@Waldz

Waldz Jul 5, 2018

Author Member

Good one. Fixed

@@ -1,14 +1,14 @@
#!/bin/bash

This comment has been minimized.

Copy link
@tadovas

tadovas Jul 4, 2018

Member

Do we still use this script ?

- BINARY=build/client/mysterium_client_linux_amd64 bin/client_package_standalone
- bin/builder_run BINARY=build/client/mysterium_client_linux_amd64 bin/client_package_debian ${VERSION} amd64

- bin/package_all $VERSION

This comment has been minimized.

Copy link
@tadovas

tadovas Jul 5, 2018

Member

Finally :)

@tadovas
Copy link
Member

left a comment

LGTM.
Bonus points for separating docker image building from docker image pushing to repo. E2e can reuse it instead of rebuilding

Waldz added some commits Jun 20, 2018

Dont need version while building Alpine dockers
Signed-off-by: Waldz <valdas@mysterium.network>
Possibility to build images without pushing
Signed-off-by: Waldz <valdas@mysterium.network>
Connect Docker packaging to CI
Signed-off-by: Waldz <valdas@mysterium.network>
Make resolvconf skip the post install
see moby/moby#1297

Signed-off-by: Waldz <valdas@mysterium.network>
Separate Docker building from releasing to Docker Hub
Signed-off-by: Waldz <valdas@mysterium.network>
Reuse packaging script in Travis
Signed-off-by: Waldz <valdas@mysterium.network>
Login to Docker before pushing
Signed-off-by: Waldz <valdas@mysterium.network>
Keep param consuming and shifting in sync
Signed-off-by: Waldz <valdas@mysterium.network>
(cherry picked from commit 9ea66c4b052b0160b87507acc2a8cbdd398f9d76)
Remove Gitgub release because Travis does artifact upload to Github
Signed-off-by: Waldz <valdas@mysterium.network>

@Waldz Waldz force-pushed the Waldz:feature/MYST-566-release-docker branch from fa61c37 to 1f15b2e Jul 5, 2018

@tadovas

tadovas approved these changes Jul 5, 2018

Copy link
Member

left a comment

reLGTM

@zolia

zolia approved these changes Jul 5, 2018

@Waldz Waldz merged commit 2e954a8 into mysteriumnetwork:master Jul 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Waldz Waldz deleted the Waldz:feature/MYST-566-release-docker branch Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.