Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYST-577 Fix missing version during "dev" builds #285

Merged
merged 11 commits into from Jul 11, 2018

Conversation

Projects
None yet
3 participants
@Waldz
Copy link
Member

commented Jul 9, 2018

No description provided.

@Waldz Waldz requested review from tadovas, interro and zolia Jul 9, 2018

@Waldz Waldz requested a review from donce as a code owner Jul 9, 2018

.travis.yml Outdated
@@ -39,18 +38,25 @@ script:

before_deploy:
- bin/travis_scripts/ensure_xgo.sh
- bin/package_all $VERSION
- bin/package_all $(cat VERSION)

This comment has been minimized.

Copy link
@zolia

zolia Jul 11, 2018

Member

do we need '$' before (cat VERSION) ?

This comment has been minimized.

Copy link
@zolia

zolia Jul 11, 2018

Member

should `cat VERSION` work?

This comment has been minimized.

Copy link
@Waldz

Waldz Jul 11, 2018

Author Member

Approach now is different

@Waldz Waldz force-pushed the Waldz:feature/MYST-577-working-releases branch 3 times, most recently from 77897e7 to 8b62ea9 Jul 11, 2018

@tadovas
Copy link
Member

left a comment

LGTM

@Waldz Waldz changed the title MYST-577 Fix missing version during "working" builds MYST-577 Fix missing version during "dev" builds Jul 11, 2018

return Version
}

version := "source"

This comment has been minimized.

Copy link
@zolia

zolia Jul 11, 2018

Member

maybe space after 'source'?

This comment has been minimized.

Copy link
@Waldz

Waldz Jul 11, 2018

Author Member

Fixed

@Waldz Waldz force-pushed the Waldz:feature/MYST-577-working-releases branch 2 times, most recently from a4d9d54 to 7feed42 Jul 11, 2018

@tadovas
Copy link
Member

left a comment

reLGTMed

@Waldz Waldz dismissed stale reviews from zolia and tadovas via 50111a9 Jul 11, 2018

Waldz added some commits Jul 9, 2018

Release Docker latest image
Signed-off-by: Waldz <valdas@mysterium.network>
Release Docker working image (on each master commit)
Signed-off-by: Waldz <valdas@mysterium.network>
Pass current version to packaging scripts
Signed-off-by: Waldz <valdas@mysterium.network>
Stop repeating build for each deploy provider
Signed-off-by: Waldz <valdas@mysterium.network>
Release several Docker images at once
Signed-off-by: Waldz <valdas@mysterium.network>
Make shorter names for locally built Docker images
Signed-off-by: Waldz <valdas@mysterium.network>
Inject semantic version during CI building
Signed-off-by: Waldz <valdas@mysterium.network>
Make 'dev' builds version compatible with Debian packages
dpkg: error processing archive /tmp/mysterium-node.deb (--install):
 parsing file '/var/lib/dpkg/tmp.ci/control' near line 2 package 'mysterium-node':
 error in 'Version' field string 'dev': version number does not start with digit
Errors were encountered while processing:
 /tmp/mysterium-node.deb

Signed-off-by: Waldz <valdas@mysterium.network>
Pass OS to standalone script
Signed-off-by: Waldz <valdas@mysterium.network>
Fix operand suffix removing for Darwin standalone
Signed-off-by: Waldz <valdas@mysterium.network>

@Waldz Waldz force-pushed the Waldz:feature/MYST-577-working-releases branch from 50111a9 to 19fa95d Jul 11, 2018

@zolia

zolia approved these changes Jul 11, 2018

@zolia

zolia approved these changes Jul 11, 2018

@tadovas
Copy link
Member

left a comment

LGTM :)

@Waldz Waldz merged commit 32a1774 into mysteriumnetwork:master Jul 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Waldz Waldz deleted the Waldz:feature/MYST-577-working-releases branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.