Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYST-637 Fix cancelable test deadlock #286

merged 1 commit into from Jul 11, 2018


None yet
3 participants
Copy link

commented Jul 11, 2018

Rewrite deadlocking test:

  1. use channels for state communication between goroutines
  2. avoid using syncGroup in tests - no possibility to wait with timeout

@tadovas tadovas requested review from Waldz and zolia Jul 11, 2018

@tadovas tadovas requested a review from donce as a code owner Jul 11, 2018

@tadovas tadovas force-pushed the hotfix/fix-cancelable-test-deadlock branch from 495513b to 0b3ae57 Jul 11, 2018


zolia approved these changes Jul 11, 2018


Waldz approved these changes Jul 11, 2018

@Waldz Waldz merged commit 70daaab into master Jul 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@Waldz Waldz deleted the hotfix/fix-cancelable-test-deadlock branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.